Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch 400 on list item unique role assignments #1610

Merged
merged 5 commits into from
Sep 11, 2023
Merged

catch 400 on list item unique role assignments #1610

merged 5 commits into from
Sep 11, 2023

Conversation

seanstory
Copy link
Member

Related to #1582

We've had reports of 400 errors when issuing requests like:

GET /sites/<site_id>/_api/lists/GetByTitle('<list_title>')/items(41)/HasUniqueRoleAssignments

which is odd, since this should be a valid request, as far as we can tell from the docs.

To prevent this from blocking syncs, we want to simply log a warning when this surfaces, and move on.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Related Pull Requests

Release Note

Log (but otherwise ignore) 400 errors that occasionally arise when requesting unique permissions from some Sharepoint Online List Items.

@seanstory seanstory requested a review from a team September 8, 2023 19:45
@seanstory seanstory enabled auto-merge (squash) September 11, 2023 13:11
@seanstory seanstory merged commit 6a845a3 into main Sep 11, 2023
@seanstory seanstory deleted the seanstory/catch-400-on-list-item-unique-role-assignments branch September 11, 2023 13:20
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@seanstory
catch 400 on list item unique role assignments (#1610)
f832f86 
* Address specific edge case of 400 on list item unique role permissions

* Don't retry 400 errors

* Autoformat
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@seanstory
catch 400 on list item unique role assignments (#1610)
6d04bc5 
* Address specific edge case of 400 on list item unique role permissions

* Don't retry 400 errors

* Autoformat
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
@github-actions
Copy link

💚 Backport PR(s) successfully created

Status Branch Result
✅ pre-8.10-stable #1612
✅ 8.10 #1613

The backport PRs will be merged automatically after passing CI.

seanstory added a commit that referenced this pull request Sep 11, 2023
@github-actions @seanstory
catch 400 on list item unique role assignments (#1610) (#1612)
5e0a49f 
* Address specific edge case of 400 on list item unique role permissions

* Don't retry 400 errors

* Autoformat

Co-authored-by: Sean Story <sean.j.story@gmail.com>
seanstory added a commit that referenced this pull request Sep 11, 2023
@github-actions @seanstory
catch 400 on list item unique role assignments (#1610) (#1613)
46e7786 
* Address specific edge case of 400 on list item unique role permissions

* Don't retry 400 errors

* Autoformat

Co-authored-by: Sean Story <sean.j.story@gmail.com>
@seanstory seanstory mentioned this pull request Sep 19, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarone-feekery navarone-feekery navarone-feekery approved these changes

Assignees
No one assigned
Labels
auto-backport release_note v8.10.1 v8.11.0 v8.11.0.0 vpre-8.10-stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanstory @navarone-feekery